Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

stable/chartmuseum fix: missing labels in secret object #21756

Merged
merged 1 commit into from
May 19, 2020
Merged

stable/chartmuseum fix: missing labels in secret object #21756

merged 1 commit into from
May 19, 2020

Conversation

sermilrod
Copy link
Contributor

What this PR does / why we need it:

This PR adds missing extra labels to secret object

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 3, 2020
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sermilrod. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sermilrod
Copy link
Contributor Author

/assign @jdolitsky

@stale
Copy link

stale bot commented May 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2020
@jdolitsky
Copy link
Contributor

@sermilrod sorry to have missed this- do you mind rebasing and fixing version?

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2020
@sermilrod
Copy link
Contributor Author

@sermilrod sorry to have missed this- do you mind rebasing and fixing version?

Yeah sure, no problem

fix: missing labels in secret object
374e43d 
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
@sermilrod sermilrod force-pushed the fix/chartmuseum-secret-labels branch from 702e595 to 374e43d Compare May 18, 2020 09:48
@sermilrod
Copy link
Contributor Author

@jdolitsky done 👍 Can you please check it again?

@jdolitsky
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2020
@jdolitsky
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdolitsky, sermilrod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3977735 into helm:master May 19, 2020
steakunderscore added a commit to steakunderscore/charts that referenced this pull request May 20, 2020
@steakunderscore
Merge remote-tracking branch 'upstream/master' into patch-1
722a1f1 
* upstream/master: (46 commits)
  [stable/anchore-engine] Fix upgrade jobs (helm#22451)
  Update MongoDB Exporter (helm#22241)
  [stable/efs-provisioner] Add podLabels support (helm#22439)
  [stable/rabbitmq-ha]  add configuration for initContainer (helm#22005)
  fix: missing labels in secret object (helm#21756)
  [stable/openebs]: fix README image repository typo (helm#22445)
  [stable/graylog] Adding option to define environment variables in raw yaml format (helm#22007)
  [stable/anchore-engine] Allow loading custom CA certificate (helm#22440)
  [stable/jenkins] Cleanup agent.yamlTemplate rendering in XML config (helm#22124)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.5.1 (helm#22438)
  [stable/neo4j] Deprecated. replacement: https://github.com/neo4j-contrib/neo4j-helm (helm#22437)
  [stable/jenkins] Render agent.nodeSelector in pod template JCasC (helm#22431)
  [incubator/sparkoperator] Add webhookNamespaceSelector (helm#22434)
  [stable/jenkins] Adding override for ingress paths (helm#22400)
  stable/unifi implements subPath functionality (helm#22432)
  [stable/prometheus] Add Namespace to applicable Resources (helm#22378)
  [incubator/patroni] Update patroni to 1.5-p5 (helm#21986)
  [kube2iam] - add labels to ServiceMonitor (helm#21605)
  [stable/fluent-bit] Enabling dnsConfig option in the Chart (helm#22419)
  [stable/jenkins] add k8s plugin config parameters (helm#22403)
  ...
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@sermilrod
fix: missing labels in secret object (helm#21756)
3fd7b4f 
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@sermilrod @includerandom
fix: missing labels in secret object (helm#21756)
ba83dad 
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@sermilrod @li-adrienloiseau
fix: missing labels in secret object (helm#21756)
a6b0179 
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@sermilrod
fix: missing labels in secret object (helm#21756)
a4817c3 
Signed-off-by: Sergio Millan Rodriguez <sergio.rodriguez@ticketmaster.co.uk>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goruha goruha Awaiting requested review from goruha

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

Assignees

@jdolitsky jdolitsky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sermilrod @k8s-ci-robot @jdolitsky @helm-bot