Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/openldap] Please add me as a mantainer #17887

Closed
wants to merge 1 commit into from

Conversation

pennycoders
Copy link

According to #13869, this chart needs some mantainers

Signed-off-by: Alexandru Bogdan Pica dtk077@gmail.com

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pennycoders. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pennycoders
To complete the pull request process, please assign maorfr
You can assign the PR to them by writing /assign @maorfr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 11, 2019
@zanhsieh
Copy link
Collaborator

@pennycoders
Please bump chart version to latest. Thank you.

According to helm#13869, this chart needs some mantainers

Signed-off-by: Alexandru Bogdan Pica <dtk077@gmail.com>
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the helm org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • pennycoders
    • stable/openldap/OWNERS

@pennycoders
Copy link
Author

Hi @zanhsieh

Just bumped the chart version to 1.2.2.

Cheers,

Alex.

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2019
@zanhsieh
Copy link
Collaborator

@maorfr @lachie83
Would you grant him as one of the OWNERS of this chart please?

@maorfr
Copy link
Member

maorfr commented Oct 21, 2019

I'll leave this to @scottrigby

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2019
@scottrigby
Copy link
Member

@pennycoders do you have any open PRs? I don't see any commits for you https://github.com/helm/charts/commits?author=pennycoders. We like to see at least some contribution history before adding people as chart OWNERS.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2019
@pennycoders
Copy link
Author

@pennycoders do you have any open PRs? I don't see any commits for you https://github.com/helm/charts/commits?author=pennycoders. We like to see at least some contribution history before adding people as chart OWNERS.

Hi @scottrigby ,

I only have a PR. It did not get merged before another which fixed the same issue though.

You can check it out at the following URL:

#17512

Thanks,

Alex.

@stale
Copy link

stale bot commented Dec 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants