[stable/kibana] Set hosts as env var only

[naseemkullah]

Signed-off-by: Naseem naseemkullah@gmail.com

What this PR does / why we need it:

setting elasticsearch.hosts by default in kibana.yml causes issues if pinning kibana to version < 6.6

This was brought up here #14062 (comment)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes [stable/kibana] FATAL ValidationError: child "elasticsearch" fails because ["hosts" is not allowed] #14062

Special notes for your reviewer:

cc @monotek @desaintmartin @Towmeykaw @mjrepo2

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[k8s-ci-robot]

Hi @naseemkullah. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Towmeykaw]

Did a quick test and it looks good to me.

[monotek]

I'm currently thinking about to use a value to create both configs (hosts & url) as env vars.
This should work for all versions without the need to change the config.

@compleatang
Whats your opinion on this?

[compleatang]

@monotek I think that would be nice. I kinda feel like we're going round and round in circles on this env var and whether the config should have defaults or be empty. I'm underwater this week but it would be nice to have a more sustainable solution in my view.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: naseemkullah
To complete the pull request process, please assign compleatang
You can assign the PR to them by writing /assign @compleatang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• stable/kibana/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[compleatang]

@naseemkullah I'm sorry about the delay in processing the chart PR. Thanks for the contribution. Unfortunately we're going to put a hold on this issue for the reasons below.

In combination with the elastic team, we've decided to deprecate stable/kibana going forward in favor of elastic/kibana. You can see the tracking issue for the work here -> #14935

We are encouraging all open issues to contribute their work to the "new" community chart led by the elastic team here -> https://github.com/elastic/helm-charts/tree/master/kibana

If you have any questions please feel free to comment on #14935

/hold

[naseemkullah]

Thanks @compleatang FYI I've made a similar PR to elastic/kibana.