Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/velero]: add me as maintainer #14031

Merged
merged 1 commit into from
May 22, 2019

Conversation

hectorj2f
Copy link
Collaborator

Based on this list, velero needs some maintainers.

related to: #13869

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hectorj2f. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hectorj2f hectorj2f force-pushed the hectorj2f/become_maintainer branch from 1de22a6 to 42708d3 Compare May 21, 2019 14:52
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 21, 2019
Signed-off-by: Hector Fernandez <hfernandez@mesosphere.com>
@hectorj2f hectorj2f force-pushed the hectorj2f/become_maintainer branch from 42708d3 to 6651869 Compare May 21, 2019 14:54
@hectorj2f hectorj2f changed the title velero: add me as maintainer [stable/velero]: add me as maintainer May 21, 2019
@maorfr
Copy link
Member

maorfr commented May 22, 2019

/assign
/ok-to-test

thanks @hectorj2f !

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2019
@maorfr
Copy link
Member

maorfr commented May 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 757baf5 into helm:master May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants