[stable/kibana] add scheme option to livenessProbe and readinessProbe

[dkoshkin]

What this PR does / why we need it:

When setting:

files:
  kibana.yml:
    server.ssl.enabled: "true"

The Liveness and Readiness probes fail and need to set the scheme option to HTTPS.

Special notes for your reviewer:

CC @compleatang @monotek

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkoshkin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: compleatang

If they are not already assigned, you can assign the PR to them by writing /assign @compleatang in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/kibana/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dkoshkin. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[s12chung]

/assign @compleatang

[monotek]

/ok-to-test

[k8s-ci-robot]

@monotek: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[monotek]

Could you add an ci test for this please?

[compleatang]

Agree with @monotek WRT having a test. Gonna trigger testing just cause I'm tied up next few days. Mono I thought you were capable of doing this...?

/ok-to-test

[monotek]

@compleatang
"lgtm" works. "ok-to-test" not ¯_(ツ)_/¯

[k8s-ci-robot]

@dkoshkin: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	fcc5385	link	/test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dkoshkin]

This is my first PR with CI tests and I don't really understand how any of the others tests are not failing:

I0403 16:01:42.966] {"type":"log","@timestamp":"2019-04-03T16:00:02Z","tags":["warning","elasticsearch","admin"],"pid":1,"message":"Unable to revive connection: http://elasticsearch:9200/"}

Do I need to do something to launch ES?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[monotek]

I've talked about such test cases with @compleatang recently. We don't have a proper solution for things which have elastic search as dependency.

We could add an requirement which is only enabled in the ci config.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[monotek]

Sorry for the delay. We're still in the discussion about proper testing in: #12628

[compleatang]

@dkoshkin sorry for the extreme delay here. Thanks for the contribution. Unfortunately we're going to put a hold on this issue for the reasons below.

In combination with the elastic team, we've decided to deprecate stable/kibana going forward in favor of elastic/kibana. You can see the tracking issue for the work here -> #14935

We are encouraging all open issues to contribute their work to the "new" community chart led by the elastic team here -> https://github.com/elastic/helm-charts/tree/master/kibana

If you have any questions please feel free to comment on #14935

/hold

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.