[stable/spinnaker] can't upgrade spinnaker

[skaji]

Describe the bug

The StatefulSet spinnaker-halyard contains a mutable value in
spec.volumeClaimTemplates.metadata.labels (i.e, (chart name)-(version))
so that we cannot upgrade the spinnaker chart.

This is the same issue as #7803

Version of Helm and Kubernetes:

❯ helm version
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}

❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-19T22:12:47Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.6-eks-d69f1b", GitCommit:"d69f1bf3669bf00b7f4a758e978e0e7a1e3a68f7", GitTreeState:"clean", BuildDate:"2019-02-28T20:26:10Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}

Which chart:

stable/spinnaker

What happened:

Could not upgrade spinnaker from 1.8.1 to 1.8.2 with the following error:

StatefulSet.apps "spinnaker-spinnaker-halyard" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden

What you expected to happen:

Be able to upgrade spinnaker from 1.8.1 to 1.8.2

How to reproduce it (as minimally and precisely as possible):

Install spinnaker 1.8.1 and upgrade it.

Anything else we need to know:

See #7803

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.