Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Commit

Permalink
[stable/pgadmin] Pr modifies pgadmin to accept enhanced_cookie_protec…
Browse files Browse the repository at this point in the history
…tion env to fix ingress issue #18568 (#21045)

* False and True should be forced otherwise it will be interpreted as boolean

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* updates enhanced_cookie_protection

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* adds the documentation of enhanced_cookie_protection in pgadmin

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* as discussed I upgrade to 1.2.2

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* Updates README.md to adds default env variables

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* the value of enhanced_cookie_protection should be double quoted

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>

* update README.md : the value of enhanced_cookie_protection should be double quoted

Signed-off-by: Rachad Abi Chahine <rachad.abi-chahine@hotmail.fr>
  • Loading branch information
RachadAbiChahine committed Feb 29, 2020
1 parent 5193f1d commit e9b01ec
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/pgadmin/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: pgAdmin is a web based administration tool for PostgreSQL database
name: pgadmin
version: 1.2.1
version: 1.2.2
appVersion: 4.18.0
home: https://www.pgadmin.org/
source: https://github.com/rowanruseler/pgadmin
Expand Down
3 changes: 3 additions & 0 deletions stable/pgadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ The command removes nearly all the Kubernetes components associated with the cha
| `nodeSelector` | Node labels for pod assignment | `{}` |
| `tolerations` | Node tolerations for pod assignment | `[]` |
| `affinity` | Node affinity for pod assignment | `{}` |
| `env.email` | pgAdmin default email | `chart@example.local` |
| `env.password` | pgAdmin default password | `SuperSecret` |
| `env.enhanced_cookie_protection` | Allows pgAdmin4 to create session cookies based on IP address | `"False"` |

Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example:

Expand Down
2 changes: 2 additions & 0 deletions stable/pgadmin/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ spec:
{{- .Values.readinessProbe | toYaml | nindent 12 }}
{{- end }}
env:
- name: PGADMIN_CONFIG_ENHANCED_COOKIE_PROTECTION
value: !!string {{ .Values.env.enhanced_cookie_protection }}
- name: PGADMIN_DEFAULT_EMAIL
value: {{ .Values.env.email }}
- name: PGADMIN_DEFAULT_PASSWORD
Expand Down
5 changes: 5 additions & 0 deletions stable/pgadmin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ env:
email: chart@example.local
password: SuperSecret

## If True, allows pgAdmin to create session cookies based on IP address
## Ref: https://www.pgadmin.org/docs/pgadmin4/4.18/config_py.html
#
enhanced_cookie_protection: "False"

persistentVolume:
## If true, pgAdmin will create/use a Persistent Volume Claim
## If false, use emptyDir
Expand Down

0 comments on commit e9b01ec

Please sign in to comment.