fix: treat boolean true as empty string

hellof2e · May 28, 2024 · f5685cd · f5685cd
1 parent df0fd70
commit f5685cd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/core/src/core/util.ts b/packages/core/src/core/util.ts
@@ -13,9 +13,17 @@ export const noop = () => {};
 
 /** set dom attribute for consistent behavior */
 export const updateDomAttr = (dom: HTMLElement, name: string, value: any) => {
-	if (value != null && (value !== false || name.indexOf('aria-') === 0)) {
-		// any truty value, or falsy aria-* values
-		dom.setAttribute(name, value);
+	let isAria = false;
+
+	if (value != null && (value !== false || (isAria = name.indexOf('aria-') === 0))) {
+		dom.setAttribute(
+			name,
+			!isAria && typeof value === 'boolean'
+				// true but not aria-*
+				? ''
+				// falsy aria-* values
+				: value
+		);
 	} else {
 		dom.removeAttribute(name);
 	}

diff --git a/packages/core/test/comp.test.ts b/packages/core/test/comp.test.ts
@@ -120,7 +120,7 @@ describe('@property', () => {
     // * boolean property with its value default to true should be ignored
     expect(node!.textContent).to.equal('false');
     // * all truthy value, or falsy value except than '' will be treated as true
-    comp!.setAttribute('testattr7', '');
+    comp!.setAttribute('testattr7', '123');
     await nextTick();
     expect(node!.textContent).to.equal('true');
     comp!.removeAttribute('testattr7');