fix(ssr): use useId for hydration and remove the need for resetServerContext (React 18+) #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @klarstrup for opening this PR: #430. I wasn't able to edit the original PR, so I've re-opened it here.
The following is the original PR description
This fixes hydration errors of the sort:
Even with proper usage of
resetServerContext()
, this error can crop up when doing sufficiently concurrent SSR.It also adds a warning for when
resetServerContext
is called unnecessarily.Following the addition of React 18 support the resettable hacky increment-only IDs can be dropped in favor of the first party
useId()
API (details: https://reactjs.org/docs/hooks-reference.html#useid)This should not be a breaking change per se but the new IDs could result in broken snapshot tests among consumers, as indeed it did here.