go: all-CAPS struct fields are highlighted differently from non-all-CAPS

[ygabuev]

Summary

Hi!

I have a following piece of Go code:

package main

type Something struct {
	FIELD      int
	Another    int
	YetAnother int
}

func main() {
	var s = Something{
		FIELD:      0,
		Another:    0,
		YetAnother: 0,
	}
}

In helix, the string FIELD - which is all-CAPS - is highlighted differently from other field names when I instantiate a struct:

Similar code in e.g. Rust doesn't have this problem:

Is this a bug? What may be causing this issue?

Platform

Arch Linux 6.5.4 x86_64

Terminal Emulator

alacritty 0.12.2

Helix Version

helix 23.05

[the-mikedavis]

This line in the Go highlight queries gives constants (all caps identifiers) the special highlighting:

helix/runtime/queries/go/highlights.scm

Line 27 in f520b16

((identifier) @constant (match? @constant "^[A-Z][A-Z\\d_]+$"))

. We should move that line down further in the file (probably next to (comment) @comment) so that it takes the least precedence.

That won't quite fix this case though. We can highlight the fields in the literal struct by adding a line to the Go highlights:

(keyed_element (literal_element (identifier) @variable.other.member))

Which would fit nicely next to

helix/runtime/queries/go/highlights.scm

Line 40 in f520b16

(field_identifier) @variable.other.member

(the line that gives struct fields their highlight in the type Something struct { .. } block)