Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more key bindings in windows, including f13-f24 #7669

Closed
AsafMah opened this issue Jul 18, 2023 · 3 comments
Closed

Support more key bindings in windows, including f13-f24 #7669

AsafMah opened this issue Jul 18, 2023 · 3 comments
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@AsafMah
Copy link

AsafMah commented Jul 18, 2023

Windows has plenty of extra keys available in the virtual keycodes:
https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes

Which is useful for extended keyboards, or people like me who map CapsLock to F13 to avoid it.. capslocking.

Currently helix explicitly forbids F13 (there is a test for that).
It would be nice if it could support any virtual key, or at least F13-F24.

@AsafMah AsafMah added the C-enhancement Category: Improvements label Jul 18, 2023
@the-mikedavis
Copy link
Member

This should be a very small change to support. This bounds check just needs to be expanded to allow up to 24:

(function > 0 && function < 13)

I'm not sure the history of that line but supporting up to 24 seems fine to me.

@the-mikedavis the-mikedavis added A-keymap Area: Keymap and keybindings E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR and removed E-good-first-issue Call for participation: Issues suitable for new contributors labels Jul 18, 2023
@christianholman
Copy link
Contributor

This should be a very small change to support. This bounds check just needs to be expanded to allow up to 24:

(function > 0 && function < 13)

I'm not sure the history of that line but supporting up to 24 seems fine to me.

submitted a PR for this and updated the test as well, saw you removed good first issue so let me know if there's anything more involved there - mostly doing this to get setup with the repo:>

@archseer
Copy link
Member

Closed by #7672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-keymap Area: Keymap and keybindings C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Development

No branches or pull requests

4 participants