Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse repeat_last_motion command #12092

Closed
Aqaao opened this issue Nov 19, 2024 · 6 comments
Closed

Add inverse repeat_last_motion command #12092

Aqaao opened this issue Nov 19, 2024 · 6 comments
Labels
C-enhancement Category: Improvements

Comments

@Aqaao
Copy link

Aqaao commented Nov 19, 2024

#8495

@Aqaao Aqaao added the C-enhancement Category: Improvements label Nov 19, 2024
@the-mikedavis
Copy link
Member

No need to duplicate the discussion, closing in favor of #8495

@the-mikedavis the-mikedavis closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@Aqaao
Copy link
Author

Aqaao commented Nov 20, 2024

No need to duplicate the discussion, closing in favor of #8495

Is Helix open to accepting PR for this feature?

@the-mikedavis
Copy link
Member

I'd be interested in a PR for this. I think I left a comment on an older PR (I can't find the link :/) with a suggestion to refactor the Motion type in helix-view/src/editor.rs to accept a second parameter Direction. That would make adding this command easier

@willbush
Copy link

I'd be interested in a PR for this. I think I left a comment on an older PR (I can't find the link :/) with a suggestion to refactor the Motion type in helix-view/src/editor.rs to accept a second parameter Direction. That would make adding this command easier

Think this is the link: #8761 (comment)

@Aqaao
Copy link
Author

Aqaao commented Feb 15, 2025

I'd be interested in a PR for this. I think I left a comment on an older PR (I can't find the link :/) with a suggestion to refactor the Motion type in helix-view/src/editor.rs to accept a second parameter Direction. That would make adding this command easier

Think this is the link: #8761 (comment)

I have completed prototype for inverse_repeat_last_motion feature, but like this issue, it doesn't handle the switching between selection mode and move mode very well. I might come back to continue working on this feature after resolving the issue.😪

@Aqaao
Copy link
Author

Aqaao commented Feb 15, 2025

If anyone is interested in this feature, they can check out this fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants