Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary selection not visible #11602

Closed
jonmon6691 opened this issue Aug 30, 2024 · 2 comments
Closed

Primary selection not visible #11602

jonmon6691 opened this issue Aug 30, 2024 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@jonmon6691
Copy link

Summary

While I was working through the tutor in section 10, I was not able to see which of the selections was the primary selection while cycling through them with the '(' and ')' keys.

I can see the numbers in the ruler on the button right updating, so I know it's working, but there's no visual feedback.

I am using the default theme and have no custom configuration in place.

image

Reproduction Steps

In normal mode, I made multiple disjoint selections by using the 's' command and searching for text in my current visual selection.

I then pressed the open paren key, '(' aka Shift+9 repeatedly.

I expected some sort of visual indication to cycle between each selection to indicate which was the primary selection. Maybe a change in hue/value or type weight.

What happened was that there was no change in the appearance of any of the selections.

Helix log

~/.cache/helix/helix.log [helix.log](https://github.com/user-attachments/files/16812046/helix.log)

Platform

Linux

Terminal Emulator

foot version: 1.18.1 +pgo +ime +graphemes -assertions

Installation Method

source

Helix Version

24.07-150-g1b5295a3

@jonmon6691 jonmon6691 added the C-bug Category: This is a bug label Aug 30, 2024
@jonmon6691
Copy link
Author

After experimenting with this swapping through the included themes, it seems the maybe less than half have a usable amount of contrast for this feature.

Dracula has really good contrast for this feature:
image

I'd be interested in tinkering with this but I can't figure out where the default theme is stored. I don't see a default.toml in the runtime/themes/ folder. And find . -name "default.toml" didn't turn anything up in the source repo.

@kirawi
Copy link
Member

kirawi commented Aug 30, 2024

duplicate of #3842

@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants