Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Níma: remove default config in webserver #6419

Closed
tomas-langer opened this issue Mar 16, 2023 · 1 comment
Closed

Níma: remove default config in webserver #6419

tomas-langer opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels
4.x Version 4.x Níma Helidon Níma P3 task To do webserver
Milestone

Comments

@tomas-langer
Copy link
Member

Currently webserver uses configuration obtained through Config.create() even when it is later explicitly set.
We should remove this and expect users to provide configuration to us through APIs (as we have in reactive).

We may use some global configuration instance configured statically (see Nima.config()), though that should return an Optional<Config>, so we ignore it unless configured by user. This must also align correctly with config driven services when Pico is used.

@tomas-langer tomas-langer added task To do webserver 4.x Version 4.x Níma Helidon Níma labels Mar 16, 2023
@tomas-langer tomas-langer added this to the 4.0.0-M2 milestone Mar 16, 2023
@m0mus m0mus added the P3 label Mar 16, 2023
@ljnelson ljnelson self-assigned this Jun 22, 2023
@m0mus m0mus assigned tomas-langer and unassigned ljnelson Jun 22, 2023
@tomas-langer
Copy link
Member Author

Fixed by #7008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x Níma Helidon Níma P3 task To do webserver
Projects
Archived in project
Development

No branches or pull requests

3 participants