Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] RC in JMS tests #6366

Closed
danielkec opened this issue Mar 6, 2023 · 2 comments · Fixed by #6375
Closed

[4.x] RC in JMS tests #6366

danielkec opened this issue Mar 6, 2023 · 2 comments · Fixed by #6375
Assignees
Labels
3.x Issues for 3.x version branch 4.x Version 4.x intermittent

Comments

@danielkec
Copy link
Contributor

Error:  Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.809 s <<< FAILURE! - in io.helidon.messaging.connectors.jms.JmsMpTest
Error:  io.helidon.messaging.connectors.jms.JmsMpTest.error  Time elapsed: 0.006 s  <<< ERROR!
java.util.ConcurrentModificationException
	at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013)
	at java.base/java.util.ArrayList$Itr.next(ArrayList.java:967)
	at org.hamcrest.collection.IsIterableContainingInAnyOrder.matchesSafely(IsIterableContainingInAnyOrder.java:26)
	at org.hamcrest.collection.IsIterableContainingInAnyOrder.matchesSafely(IsIterableContainingInAnyOrder.java:16)
	at org.hamcrest.TypeSafeDiagnosingMatcher.matches(TypeSafeDiagnosingMatcher.java:55)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:12)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at io.helidon.messaging.connectors.jms.AbstractMPTest.produceAndCheck(AbstractMPTest.java:59)
	at io.helidon.messaging.connectors.jms.AbstractMPTest.produceAndCheck(AbstractMPTest.java:42)
	at io.helidon.messaging.connectors.jms.JmsMpTest.error(JmsMpTest.java:231)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.jboss.weld.bean.proxy.AbstractBeanInstance.invoke(AbstractBeanInstance.java:38)
	at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:106)
	at io.helidon.messaging.connectors.jms.JmsMpTest$Proxy$_$$_WeldClientProxy.error(Unknown Source)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
@danielkec danielkec added 3.x Issues for 3.x version branch intermittent 4.x Version 4.x labels Mar 6, 2023
@danielkec danielkec self-assigned this Mar 6, 2023
@spericas
Copy link
Member

spericas commented Mar 6, 2023

Maybe just this?

diff --git a/tests/integration/jms/src/test/java/io/helidon/messaging/connectors/jms/AbstractMPTest.java b/tests/integration/jms/src/test/java/io/helidon/messaging/connectors/jms/AbstractMPTest.java
index eed5e42585..b314d6c0fe 100644
--- a/tests/integration/jms/src/test/java/io/helidon/messaging/connectors/jms/AbstractMPTest.java
+++ b/tests/integration/jms/src/test/java/io/helidon/messaging/connectors/jms/AbstractMPTest.java
@@ -56,7 +56,10 @@ public abstract class AbstractMPTest extends AbstractJmsTest {
                     expected.toString(), consumingBean.consumed().toString()));
         }
         if (!expected.isEmpty()) {
-            assertThat(consumingBean.consumed(), Matchers.containsInAnyOrder(expected.toArray()));
+            // This list requires a synchronized block for traversing
+            synchronized (consumingBean.consumed()) {
+                assertThat(consumingBean.consumed(), Matchers.containsInAnyOrder(expected.toArray()));
+            }
         }
     }

@danielkec danielkec changed the title RC in JMS tests [4.x] RC in JMS tests Mar 7, 2023
@danielkec
Copy link
Contributor Author

Its a missed test checking functionality from Messaging 1.0 and worked by chance, probability of the failure rizen when period-executions got configured to lower value for making test running faster.

@danielkec danielkec linked a pull request Mar 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch 4.x Version 4.x intermittent
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants