Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] JMS connector - Injected javax.jms.ConnectorFactory #6291

Closed
danielkec opened this issue Feb 25, 2023 · 0 comments · Fixed by #6305
Closed

[4.x] JMS connector - Injected javax.jms.ConnectorFactory #6291

danielkec opened this issue Feb 25, 2023 · 0 comments · Fixed by #6305
Assignees
Labels
3.x Issues for 3.x version branch 4.x Version 4.x messaging Reactive Messaging
Milestone

Comments

@danielkec
Copy link
Contributor

danielkec commented Feb 25, 2023

JMS connector accepts only jakarta.jms.ConnectorFactory injected as a bean.

So for legacy javax clients manual usage of the shim tooling is needed.

    @Produces
    @ApplicationScoped
    @Named("activemq-cf")
    public jakarta.jms.ConnectionFactory connectionFactory() {
        return JakartaJms.create(new ActiveMQConnectionFactory("tcp://127.0.0.1:61616"));
    }

We should make shim usage implicit/seamless.

    @Produces
    @ApplicationScoped
    @Named("activemq-cf")
    public javax.jms.ConnectionFactory connectionFactory() {
        return new ActiveMQConnectionFactory("tcp://127.0.0.1:61616");
    }
@danielkec danielkec added messaging Reactive Messaging 3.x Issues for 3.x version branch 4.x Version 4.x labels Feb 25, 2023
@danielkec danielkec changed the title JMS connector - Injected javax.jms.ConnectorFactory [4.x] JMS connector - Injected javax.jms.ConnectorFactory Feb 28, 2023
@danielkec danielkec linked a pull request Feb 28, 2023 that will close this issue
@danielkec danielkec added this to the 4.0.0-M1 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch 4.x Version 4.x messaging Reactive Messaging
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant