Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom exception in CharBuffer #5377

Closed
tomas-langer opened this issue Nov 11, 2022 · 0 comments · Fixed by #5505
Closed

Use custom exception in CharBuffer #5377

tomas-langer opened this issue Nov 11, 2022 · 0 comments · Fixed by #5505
Assignees
@aserkes
Labels
media-support Media type processing in SE task To do

Comments

@tomas-langer
Copy link
Member

The reactive/media/common/src/main/java/io/helidon/reactive/media/common/CharBuffer.java is using OutOfMemoryError as an exception.
This should not be done - OOM is reserved to be thrown by the JVM when it runs out of memory, not by us when we are "afraid of running out of memory".

This should be changed to a custom runtime exception (not an Error)
@tomas-langer tomas-langer added task To do media-support Media type processing in SE labels Nov 11, 2022
This was referenced Nov 22, 2022
Merged
Closed
@aserkes aserkes linked a pull request Nov 28, 2022 that will close this issue
5377 custom exception for CharBuffer #5505
Merged
@aserkes aserkes closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aserkes aserkes

Labels
media-support Media type processing in SE task To do
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5377 custom exception for CharBuffer aserkes/helidon
2 participants
@tomas-langer @aserkes