Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Doc Bugs 3.0 #4673

Closed
25 of 27 tasks
ljamen opened this issue Aug 4, 2022 · 2 comments
Closed
25 of 27 tasks

General Doc Bugs 3.0 #4673

ljamen opened this issue Aug 4, 2022 · 2 comments
Assignees
Labels
3.x Issues for 3.x version branch docs
Milestone

Comments

@ljamen
Copy link
Contributor

ljamen commented Aug 4, 2022

Environment Details

  • Helidon Version: 3.0
  • Helidon SE and Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

SE
Docs that have missing TOCs:

Docs that have TOC formatting issues:

Docs not using new template:

Lowercase Se

Docs that have TOC formatting issues:
<>
https://helidon.io/docs/v3/#/mp/persistence
https://helidon.io/docs/v3/#/mp/persistence needs to be reworked_

Docs not using new template:

Lowercase Mp

From Tim: I think the new/latest approach is that an MP .adoc file has an include::{rootdir}/includes/mp.adodc[] and the obvious parallel for SE.

Formatting issues:

  • On this page https://helidon.io/docs/latest/index.html#/mp/security/providers#OIDC-Provider in the CORS Settings section:
    The CORS Settings header looks to be at too high a level (== instead of === I think in docs/includes/security/providers/oidc.adoc). The first sentence there refers to the cors block under the oidc block of the configuration.

  • Just below that on that same rendered page is a bad include . It looks as if the problem is at docs/includes/cors.adoc line 93. AsciiDoc requires a file (even for references to tags in the same file according to its documentation) but none is there. Locally as a test I inserted cors.adoc (the current file) just after the :: and my IDE rendered the expected table correctly.
    helidon.iohelidon.io
    Introduction
    Helidon

As of 3.x, Helidon docs have adopted a new doc template:

Overview
Maven Coordinates
Usage
API
Configuration
Examples*
Additional Information*
*use if applicable

@ljamen ljamen added docs 3.x Issues for 3.x version branch labels Aug 4, 2022
@ljamen ljamen added this to the 3.0.1 milestone Aug 4, 2022
@ljamen ljamen self-assigned this Aug 4, 2022
@ljamen
Copy link
Contributor Author

ljamen commented Aug 11, 2022

FIXED: mp/config/introduction.adoc says ToC needs to change to Contents https://github.com/oracle/helidon/pull/4477/files

https://helidon.io/docs/v3/#/mp/config/advanced-configuration

@ljamen
Copy link
Contributor Author

ljamen commented Jan 12, 2023

PR #5614 addresses most of these issues. Closing as PR was merged.

@ljamen ljamen closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch docs
Projects
None yet
Development

No branches or pull requests

3 participants