Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helidon Config should not depend on Reactive #4195

Closed
tomas-langer opened this issue May 11, 2022 · 0 comments · Fixed by #4229
Closed

Helidon Config should not depend on Reactive #4195

tomas-langer opened this issue May 11, 2022 · 0 comments · Fixed by #4229
Assignees
@barchetta
Labels
2.x Issues for 2.x version branch BOSS FA Boss / RS bug Something isn't working config P2
Milestone
2.5.1

Comments

@tomas-langer
Copy link
Member

Currently we never use reactive in production code of Config.
We should remove this dependency.
Unfortunatelly it does a requires transitive on io.helidon.common.reactive, so removing this will most likely cause failures in other modules.
@tomas-langer tomas-langer added bug Something isn't working config 2.x Issues for 2.x version branch labels May 11, 2022
@trentjeff trentjeff added the BOSS FA Boss / RS label May 11, 2022
@barchetta barchetta added this to the 2.5.1 milestone May 12, 2022
@barchetta barchetta added the P2 label May 16, 2022
@barchetta barchetta self-assigned this May 16, 2022
This was referenced May 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch BOSS FA Boss / RS bug Something isn't working config P2
Projects
Backlog
Archived in project
Milestone
2.5.1
Development

Successfully merging a pull request may close this issue.

3.x: Remove dependency on helidon-common-reactive from config (#4225) barchetta/helidon
3 participants
@barchetta @tomas-langer @trentjeff