-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger Tracer returns null activeSpan for traced request #3194
Comments
@gmpatter You seem to suggest this was the result of upgrading to 2.3.2. Which version did you upgrade from? |
@spericas our apps are currently on 2.3.0. But when I reproduced this with the helidon-quickstart-mp app, I couldn't reproduce with 2.3.1 but could reproduce with 2.3.2. Sorry, would have been helpful if I'd added that! Also tried switching from jaeger dependency to zipkin but didn't see the issue. So seemed to be specific to the jaeger dependency. |
This is related to the PR #3134. This improvement assumed switching-and-forgetting a thread and resuming processing in another. However, if any other context switch happens between the time the tracing pre-matching filter runs and the resource method is invoked, the original span set by that pre-matching filter will be lost. Such a context switch is triggered by the |
PR #3207 |
Environment Details
Problem Description
With Helidon MP 2.3.2 I’m seeing an issue with Tracing. If I add @Traced annotation to an endpoint method and then try to access the active span using the injected Tracer instance, there is no active span, so getting a NPE trying to log to the span within the endpoint method
Steps to reproduce
Create a new helidon-quickstart-mp application.
Add the tracing and jaeger dependencies:
Update the GET endpoint to be traced and use the opentracing api to log to the active span:
The text was updated successfully, but these errors were encountered: