Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Helidon MP: Maven command does not create ExampleResource #2608

Closed
tvallin opened this issue Dec 15, 2020 · 3 comments
Closed
Assignees

Comments

@tvallin
Copy link
Member

tvallin commented Dec 15, 2020

The Helidon MP Data Source Guide ask to update ExampleResource class but this class is not present into the sample project.
There is instead GreetResource class.

REPRODUCER:

mvn -U archetype:generate \
    -DinteractiveMode=false \
    -DarchetypeGroupId=io.helidon.archetypes \
    -DarchetypeArtifactId=helidon-bare-mp \
    -DarchetypeVersion=2.1.1-SNAPSHOT \
    -DgroupId=io.helidon.example \
    -DartifactId=helidon-ds \
    -Dpackage=io.helidon.example.ds \
    -DrestResourceName=ExampleResource \
    -DapplicationName=ExampleApplication  

NOTE:

  • The parameter -DrestResourceName=ExampleResource does not "rename" the GreetResource. But following the guide with GreetResource instead of ExamplesResource works perfectly fine.
  • Is it useful to keep -DapplicationName=ExampleApplication as it is not used ?
@ljnelson
Copy link
Member

Thanks for the report. I just recently updated some related documentation and I think I missed this. I'll assign it to myself.

@Captain1653
Copy link
Contributor

Is it issue still valid? I tried to find it in the docs, but I couldn't.

@ljamen
Copy link
Contributor

ljamen commented Mar 28, 2024

@ljnelson I think this can be closed now. I see the changes in your other PR.

@ljamen ljamen closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants