Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/metrics output incorrect when multiple metrics share the same name #2239

Closed
tjquinno opened this issue Aug 6, 2020 · 0 comments · Fixed by #2240
Closed

/metrics output incorrect when multiple metrics share the same name #2239

tjquinno opened this issue Aug 6, 2020 · 0 comments · Fixed by #2240
Assignees
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working metrics P2 SE

Comments

@tjquinno
Copy link
Member

tjquinno commented Aug 6, 2020

Environment Details

  • Helidon Version: 1.x, 2.x
  • Helidon SE
  • JDK version:n/a
  • OS:n/a
  • Docker version (if applicable):n/a

Problem Description

There were several related but different problems involving multiple metrics having the same name (which is permitted if they have different tags).

  1. The Prometheus/OpenMetrics output mandates that the TYPE for a given metric must appear only once in the output. The ConcurrentGauge and Meter implementations did not honor this requirement.

  2. The /metrics/{registry}/{metricName} endpoint returns only a single metric but should return all metrics matching the name, regardless of tags.

Steps to reproduce

Create multiple metrics of the same metric type sharing the same name bug different tags, then access the application's /metrics/{registry}/{metricName} endpoint. The output reports only one metric instance, not all of them. The problems with ConcurrentGauge and Meter appeared when that first issue was corrected.

@tjquinno tjquinno added bug Something isn't working SE metrics P2 1.x Issues for 1.x version branch 2.x Issues for 2.x version branch labels Aug 6, 2020
@tjquinno tjquinno self-assigned this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working metrics P2 SE
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant