Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: table formatting in Security Providers page is difficult to read #1599

Closed
barchetta opened this issue Mar 30, 2020 · 9 comments
Assignees
Labels
2.x Issues for 2.x version branch docs P5

Comments

@barchetta
Copy link
Member

Environment Details

  • Helidon Version: 1.4.4

Problem Description

As reported by the user:

"This page is really difficult to read. It it possible to remove the table__overflow class to
allow the contents to wrap? (Slight alternating row colours would be a bonus too!) 🙂 https://helidon.io/docs/latest/#/security/02_providers"

@barchetta barchetta added docs 1.x Issues for 1.x version branch 2.x Issues for 2.x version branch labels Mar 30, 2020
@barchetta barchetta changed the title Documentat: table formatting in Security Providers page is difficult to read Documentation: table formatting in Security Providers page is difficult to read Mar 30, 2020
@m0mus m0mus added the P5 label Apr 2, 2020
@ljamen
Copy link
Contributor

ljamen commented Apr 17, 2020

@barchetta @m0mus,
I realize this a a low priority issue, but I'm running into this in other topics as well. Is there a global change that can be made and applied to all existing tables ( table overflow class)? I'm hesitant to use tables at all right now because of the way some are rendering. Sometimes bulleted lists aren't a great substitute.

@m0mus
Copy link
Contributor

m0mus commented Apr 19, 2020

@danielkec can you take a look on this issue?

@danielkec
Copy link
Contributor

@ljamen We can do some fine tuning of the default mode, can it be like this? helidon-io/helidon-build-tools/pull/104

@ljamen
Copy link
Contributor

ljamen commented Apr 23, 2020

The wrapped table is better. Ideally we could limit the spread of the table to 75% so that it wrapped even more, but in this case a table probably shouldn't have been used. Will these changes automatically apply to the existing tables in the site or do we have to go in to each topic and adjust?

3 similar comments
@ljamen
Copy link
Contributor

ljamen commented Apr 23, 2020

The wrapped table is better. Ideally we could limit the spread of the table to 75% so that it wrapped even more, but in this case a table probably shouldn't have been used. Will these changes automatically apply to the existing tables in the site or do we have to go in to each topic and adjust?

@ljamen
Copy link
Contributor

ljamen commented Apr 23, 2020

The wrapped table is better. Ideally we could limit the spread of the table to 75% so that it wrapped even more, but in this case a table probably shouldn't have been used. Will these changes automatically apply to the existing tables in the site or do we have to go in to each topic and adjust?

@ljamen
Copy link
Contributor

ljamen commented Apr 23, 2020

The wrapped table is better. Ideally we could limit the spread of the table to 75% so that it wrapped even more, but in this case a table probably shouldn't have been used. Will these changes automatically apply to the existing tables in the site or do we have to go in to each topic and adjust?

@danielkec
Copy link
Contributor

PR helidon-io/helidon-build-tools/pull/104 is part of 2.0.0-M3, can we close this issue?

@barchetta barchetta removed the 1.x Issues for 1.x version branch label May 21, 2020
@barchetta
Copy link
Member Author

Yes. That looks good enough for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch docs P5
Projects
Archived in project
Development

No branches or pull requests

4 participants