Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #1419

Closed
6 tasks done
tomas-langer opened this issue Feb 20, 2020 · 1 comment · Fixed by #2579 or #2583
Closed
6 tasks done

Update examples #1419

tomas-langer opened this issue Feb 20, 2020 · 1 comment · Fixed by #2579 or #2583
Assignees
Milestone

Comments

@tomas-langer
Copy link
Member

tomas-langer commented Feb 20, 2020

Update examples:

MP:

  • only use META-INF/microprofile-config.properties and application.yaml on the classpath for MP
  • Remove setup of logging.properties, done automatically now - PR Logging setup in examples and templates #2583
  • Remove Main classes unless they do something important (and use io.helidon.microprofile.cdi.Main as the main class)
  • Remove application classes unless they are significant (e.g. add @ApplicationPath that diffes from /)
  • Use ${key} instead of '{ALIAS=key} in all examples - PR Using config reference instead of ${ALIAS= #2579

SE:

  • Use Helidon WebClient for tests and examples
@tomas-langer tomas-langer added this to the 2.0.0 milestone Feb 20, 2020
@barchetta
Copy link
Member

Some of this addressed by PR #1715

@romain-grecourt romain-grecourt modified the milestones: 2.0.0, 2.0.1 Jun 18, 2020
@m0mus m0mus modified the milestones: 2.0.0, 2.0.1 Jun 18, 2020
@m0mus m0mus modified the milestones: 2.0.1, 2.0.2 Jun 29, 2020
@tomas-langer tomas-langer self-assigned this Jul 2, 2020
@m0mus m0mus modified the milestones: 2.0.2, 2.2.0, 2.1.1 Nov 12, 2020
@tomas-langer tomas-langer linked a pull request Dec 7, 2020 that will close this issue
@tomas-langer tomas-langer linked a pull request Dec 7, 2020 that will close this issue
@tomas-langer tomas-langer added this to the 2.2.0 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment