Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme always leans towards system theme #457

Closed
cbluth opened this issue Feb 18, 2025 · 6 comments
Closed

Theme always leans towards system theme #457

cbluth opened this issue Feb 18, 2025 · 6 comments

Comments

@cbluth
Copy link

cbluth commented Feb 18, 2025

i like to run my vscode in dark theme, and my drawio extension in light mode, this allows me to have a sense of contrasted working spaces, and i find it difficult to focus on the dark-themed drawio.

since upgrading to the following versions, i have had problems selecting the theme of drawio.

Version: 1.97.2 (Universal)
Commit: e54c774e0add60467559eb0d1e229c6452cf8447
Date: 2025-02-12T23:20:35.343Z
Electron: 32.2.7
ElectronBuildId: 10982180
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 23.5.0
Name: Draw.io Integration
Id: hediet.vscode-drawio
Description: This unofficial extension integrates Draw.io into VS Code.
Version: 1.8.250217011
Publisher: Henning Dieterichs
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=hediet.vscode-drawio

i cannot set my vscode to dark theme (default dark theme), and then set my drawio to something light themed (kennedy-light), it used to be possible in 1.7

@mpolitze
Copy link

This seems to be a duplicate of #456

@wieczorekmariusz
Copy link

Yes, but it's closed. @hediet maybe you could reopen it?

@hediet hediet closed this as completed in 132921f Feb 19, 2025
@hediet
Copy link
Owner

hediet commented Feb 19, 2025

Since drawio tends to have issues in the dark theme, I reverted the change to automatically follow the VS Code theme.
Now, it will use the light theme by default, regardless of what VS Code uses.

@wieczorekmariusz
Copy link

Just to confirm that v1.9 behavior is that for VS dark mode I get dark diagrams UI for "automatic" and "dark" theme and light diagrams for others.

Image

Thanks for the fix.

@cbluth
Copy link
Author

cbluth commented Feb 21, 2025

working great, thanks for this, helps my eyes too! 🎉

@hediet
Copy link
Owner

hediet commented Feb 21, 2025

@wieczorekmariusz that screenshot does not look like from v1.9 - there should only be "min" and "kennedy" available 🤔

For "appearance", there is light, dark and automatic. automatic means it follows the VS Code dark/light mode.
Default is now light (in 1.7/8 it was automatic, in <=1.6 it was effectively light)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants