Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Build System] Moving workspaces to library files #108

Open
SergioRibera opened this issue Oct 24, 2024 · 0 comments
Open

[New Build System] Moving workspaces to library files #108

SergioRibera opened this issue Oct 24, 2024 · 0 comments
Labels
cli This issue is related to the CLI core This issue is related to the core functionality

Comments

@SergioRibera
Copy link
Contributor

Currently the file structure looks like this

proyect/
  Cargo.toml
  znap.toml
  collections/
    send-donation/
      Cargo.toml
      src/lib.rs
    other/
      Cargo.toml
      src/lib.rs

The new proposal is intended to look like this

proyect/
  Cargo.toml
  znap.toml
  collections/
    send_donation.rs
    other.rs

This is not only possible but reduces many possible problems, this is possible but requires modifying the toml, so it would be nice to implement these changes to the migration command, by the toml charge, it can be like this and manage certain changes based on features

# changes on Cargo.toml

[[bin]]
name = "collection_name"
path = "collections/collection_name.rs"

[[bin]]
name = "other_collection_name"
path = "collections/other_collection_name.rs"

The macro structure and code are not affected, but the build commands are probably affected by obliterating the --bin collection_name arguments

Important

All changes should PR to the runtime branch

@SergioRibera SergioRibera added cli This issue is related to the CLI core This issue is related to the core functionality labels Oct 24, 2024
@SergioRibera SergioRibera added this to the New Build System milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli This issue is related to the CLI core This issue is related to the core functionality
Projects
None yet
Development

No branches or pull requests

1 participant