Add go-tuf interop test suite #213
Conversation
erickt
changed the title
tests/interop/go-tuf/generate.go
Outdated
| @@ -0,0 +1,19 @@ | |||
| package main | |||
There was a problem hiding this comment.
I don't think this will build because it'll pull the wrong go-tuf. Instead of leaving this here, maybe point to the commit from upstream that these were taken from? It makes more sense to generate locally and then copy out anyway IMO.
Also, that implies that you should probably call this directory M3, since nothing will keep it in sync with go-tuf's master; all of these directories are snapshots.
There was a problem hiding this comment.
Good idea.
Regarding the name, I think we should also link it to our fork, so I prefixed the directory with fuchsia-. I don't want to use M3 though, since this metadata isn't what we called M3. I instead named this directory fuchsia-go-tuf-HEAD, and called out the specific commit in the README. That sound good?
| @@ -0,0 +1,146 @@ | |||
| package main | |||
There was a problem hiding this comment.
Instead of having this file, I think it'd make more sense to leave a README here explaining where this metadata came from
There was a problem hiding this comment.
Likewise, I removed the go file, added README, and renamed this fuchsia-go-tuf-transition-M4.
|
Updated with the following changes: |
We want to make sure that rust-tuf is compatible with Fuchsia's go-tuf fork, and eventually other TUF implementations. This patch starts that process by importing the Fuchsia [go-tuf] test metadata into the rust-tuf repository in order to make sure rust-tuf can parse the metadata. There are two sets of metadata: * go-tuf-5527fe: what the library currently generates. * go-tuf-transition-M4: what the library will eventually generate once all the patches have landed. In order to ease review, this patch only includes the metadata, and a separate patch will add the integration test. [go-tuf]: https://fuchsia.googlesource.com/third_party/go-tuf/+/refs/heads/master/client/testdata/
This adds a test to rust-tuf that verifies it can successfully parse the fuchsia go-tuf fork's TUF 1.0 metadata. Unfortunately due to theupdateframework#225, we can't correctly parse all the metadata yet, so this patch just ignores that output for now.
We want to make sure that rust-tuf is compatible with go-tuf, and other TUF implementations. This patch starts that process by importing the [go-tuf] test metadata into the rust-tuf repository in order to make sure rust-tuf can parse the metadata. There are two sets of metadata:
Unfortunately due to a few bugs (#224, #225, and #226), we can't correctly parse all the metadata yet, so this patch just ignores that output for now.
I recommend reviewing each patch individually, which might be easier to review.