Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBERF-5467: remove hidden notifications and use Lazy on inbox #4632

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

kristina-fefelova
Copy link
Member

@kristina-fefelova kristina-fefelova commented Feb 14, 2024

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does a local formatting is applied (rush format)
  • - Does a local svelte-check is applied (rush svelte-check)
  • - Does a local UI tests are executed UI Testing
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

Contributor requirements

  • - Sign-off is provided. DCO
  • - GPG Signature is provided. GPG

Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
haiodo
haiodo previously approved these changes Feb 14, 2024
Signed-off-by: Kristina Fefelova <kristin.fefelova@gmail.com>
@haiodo haiodo merged commit 58f56c1 into main Feb 14, 2024
7 checks passed
@haiodo haiodo deleted the remove-hidden-notifications-5467 branch February 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants