Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-1091: Fix attach button #3854

Merged
merged 1 commit into from
Oct 18, 2023
Merged

UBER-1091: Fix attach button #3854

merged 1 commit into from
Oct 18, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Oct 18, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-1091: Fix attach button
0578c56 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from aonnikov October 18, 2023 10:45
@BykhovDenis BykhovDenis merged commit 343d72a into main Oct 18, 2023
@BykhovDenis BykhovDenis deleted the UBER-1091 branch October 23, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov approved these changes

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haiodo @aonnikov @BykhovDenis