Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-667: UI fixes, displaying All day, time editor. #3619

Merged
merged 2 commits into from
Aug 23, 2023
Merged

UBER-667: UI fixes, displaying All day, time editor. #3619

merged 2 commits into from
Aug 23, 2023

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Aug 22, 2023

Contribution checklist

Brief description

Снимок экрана 2023-08-22 в 22 15 50 Снимок экрана 2023-08-22 в 22 16 10

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues
UBER-667

SasLord added 2 commits August 22, 2023 22:24
@SasLord
UBER-667: UI fixes, displaying All day, time editor.
fcc0670 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Fix
e5a9733 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@BykhovDenis BykhovDenis merged commit 9986894 into main Aug 23, 2023
@BykhovDenis BykhovDenis deleted the fixes-uber-667 branch August 23, 2023 03:32
annano pushed a commit that referenced this pull request Aug 24, 2023
@SasLord @annano
UBER-667: UI fixes, displaying All day, time editor. (#3619)
0edbc16 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasLord @BykhovDenis