Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1574: Accurate time reports count #3509

Merged
merged 1 commit into from
Jul 19, 2023
Merged

TSK-1574: Accurate time reports count #3509

merged 1 commit into from
Jul 19, 2023

Conversation

aonnikov
Copy link
Member

@aonnikov aonnikov commented Jul 19, 2023 •
edited
Loading

Implement more accurate reports count:

  • return 0 instead of -1 when Mongo returns no results
  • call query callback when total count changes
  • add ui test

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@aonnikov aonnikov requested a review from BykhovDenis July 19, 2023 07:15
@aonnikov aonnikov force-pushed the tsk-1574-reported-time-count branch from 1c7775b to 4cb1272 Compare July 19, 2023 07:20
@aonnikov aonnikov force-pushed the tsk-1574-reported-time-count branch from 4cb1272 to d022cfc Compare July 19, 2023 07:36
@aonnikov
TSK-1574: Accurate time reports count
2524076 
Implement more accurate reports count:
- return 0 instead of -1 when Mongo returns no results
- call query callback when total count changes
- add ui test

Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
@aonnikov aonnikov force-pushed the tsk-1574-reported-time-count branch from d022cfc to 2524076 Compare July 19, 2023 08:18
@BykhovDenis BykhovDenis merged commit 046de0d into main Jul 19, 2023
@aonnikov aonnikov deleted the tsk-1574-reported-time-count branch July 25, 2023 04:29
annano pushed a commit that referenced this pull request Aug 24, 2023
@aonnikov @annano
TSK-1574: Accurate time reports count (#3509)
accd78f 
Signed-off-by: Alexander Onnikov <alexander.onnikov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aonnikov @BykhovDenis