Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBER-174: Introduce createOn every there #3222

Merged
merged 3 commits into from
May 19, 2023
Merged

UBER-174: Introduce createOn every there #3222

merged 3 commits into from
May 19, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented May 19, 2023

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
UBER-174: Introduce createOn every there
80f1093 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis May 19, 2023 12:40
haiodo added 2 commits May 19, 2023 22:51
@haiodo
Fix build
e63d582 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo
Fix svelte-check
a78c918 
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo merged commit c0bb68b into main May 19, 2023
@haiodo haiodo deleted the UBER-174 branch May 19, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis