Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1158: remove component from sprint. Remove logic for changing component on sprint change #2998

Merged
merged 1 commit into from
Apr 18, 2023
Merged

TSK-1158: remove component from sprint. Remove logic for changing component on sprint change #2998

merged 1 commit into from
Apr 18, 2023

Conversation

ThetaDR
Copy link
Contributor

@ThetaDR ThetaDR commented Apr 17, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-1158

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@ThetaDR ThetaDR requested a review from haiodo April 17, 2023 11:44
haiodo
haiodo requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove component field, and grouping based on it.

@ThetaDR ThetaDR requested a review from haiodo April 18, 2023 07:29
@ThetaDR
TSK-1158: remove component from sprint. Remove logic for changing com…
5f58864 
…ponent on sprint change

Signed-off-by: Vyacheslav Tumanov <me@slavatumanov.me>
@ThetaDR
Copy link
Contributor Author

ThetaDR commented Apr 18, 2023

Discussed to fully remove component from sprint

@haiodo haiodo merged commit 7fdb585 into main Apr 18, 2023
@haiodo haiodo deleted the TSK-1158 branch April 18, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThetaDR @haiodo