Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSK-1093: Fix Application doneState showing #2927

Merged
merged 1 commit into from
Apr 10, 2023
Merged

TSK-1093: Fix Application doneState showing #2927

merged 1 commit into from
Apr 10, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Apr 10, 2023

Contribution checklist

Brief description

https://front.hc.engineering/workbench/platform/tracker/TSK-1093

  • Add comments loading progress.
  • Increase limits to standard 200 on popups.
  • Fix doc preview extra close button displayed.
  • Make markdown presentation a bit more compact.
  • Allow to run prod with dev-production and connect to production host.

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo haiodo requested a review from BykhovDenis April 10, 2023 05:12
* Add comments loading progress.
* Increase limits to standard 200 on popups.
* Fix doc preview extra close button displayed.
* Make markdown presentation a bit more compact.
* Allow to run prod with dev-production and connect to production host.

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@BykhovDenis BykhovDenis merged commit d353c0e into main Apr 10, 2023
@BykhovDenis BykhovDenis deleted the TSK-1093 branch April 10, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants