Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Board: Update popups style #2043

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Board: Update popups style #2043

merged 2 commits into from
Jun 9, 2022

Conversation

annano
Copy link
Contributor

@annano annano commented Jun 9, 2022 •
edited
Loading

Signed-off-by: Anna No anna.no@xored.com
checklist
copy
move

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@annano
Board: Update popups style
5a1d8b8 
Signed-off-by: Anna No <anna.no@xored.com>
@annano annano requested review from haiodo and SasLord June 9, 2022 08:54
@annano annano linked an issue Jun 9, 2022 that may be closed by this pull request
Make all popups consistent with application standard #1724
Closed
@annano
Board: Update popups style
0ce4a0a 
Signed-off-by: Anna No <anna.no@xored.com>
@haiodo haiodo merged commit 2997efd into main Jun 9, 2022
@haiodo haiodo deleted the ano/update-board-popups branch June 9, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

@SasLord SasLord Awaiting requested review from SasLord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all popups consistent with application standard
2 participants
@annano @haiodo