Tracker: change "Issue" type to "AttachedDoc" #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
ghost
marked this pull request as draft
added 5 commits
May 26, 2022 20:27
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
ghost
marked this pull request as ready for review
added 4 commits
June 1, 2022 09:44
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
reviewed
Jun 2, 2022
| @@ -30,7 +30,15 @@ | |||
| const newDueDate = detail && detail?.getTime() | |||
|
|
|||
| if (shouldSaveOnChange && newDueDate !== undefined && newDueDate !== value.dueDate) { | |||
| await client.update(value, { dueDate: newDueDate }) | |||
| await client.updateCollection( | |||
There was a problem hiding this comment.
It was not necessary, please check and update in next PR. client.update internally check for derived class for attached documents and automatically perform required changes.
haiodo
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1786