Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Directory class #167

Open
benjaminLuoHC opened this issue Apr 23, 2024 · 0 comments
Open

Split Directory class #167

benjaminLuoHC opened this issue Apr 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@benjaminLuoHC
Copy link
Contributor

benjaminLuoHC commented Apr 23, 2024

Define a base Directory class with get_files and filter, then make separate report classes that inherit from it

The current directory class is too big

Proposed usage:

from file_processing import MetadataReport, AnalyticsReport, SimilarityReport

MetadataReport('path/to/dir', **kwargs)
AnalyticsReport(...)
...

Proposed implementation

class Directory()
# init
# get_files
# filter
class MetadataReport(Directory)
# methods

Note: Tests would need minor refactoring

@BrennanHCSC BrennanHCSC added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants