feat(state) support multiple files in args #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raittes
force-pushed
the
state-flag-multiple-args
branch
from
0d61ea6
to
74eebfe
Compare
|
Can you please add a test case in the |
raittes
force-pushed
the
state-flag-multiple-args
branch
from
e1a1857
to
6e13955
Compare
|
done @hbagdi |
hbagdi
requested changes
Apr 3, 2020
cmd/sync.go
Outdated
| syncCmd.Flags().StringVarP(&syncCmdKongStateFile, | ||
| "state", "s", "kong.yaml", "file containing Kong's configuration. "+ | ||
| syncCmd.Flags().StringSliceVarP(&syncCmdKongStateFile, | ||
| "state", "s", []string{"kong.yaml"}, "file containing Kong's configuration. "+ |
There was a problem hiding this comment.
Let's change the help test to instead:
file(s) containing Kong's configuration.
This flag can be specified multiple times for multiple files.
Use '-' to read from stdin.
Please note the line jumps. We want that in the --help output.
Please change this in all other commands as well.
| assert := assert.New(t) | ||
| assert.Equal("-", filename) | ||
| assert.Equal("-", filenames[0]) |
There was a problem hiding this comment.
There is an interesting case where some configuration can be specified via Stdin and other via flag.
I was considering to restrict - as standalone, meaning you either specify only file(s) or only Stdin.
I think it is okay to allow it.
Just leaving a thought. No changes required.
hbagdi
approved these changes
Apr 3, 2020
|
Thank you @hbagdi! |
|
Expect a release in a couple of weeks. |
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
I have different state-directories for each environment (ex: production, staging)
And I want to have common configuration for both environments,
so I could create a symlink for a common directory inside each environment directory.
(ex: production/common -> ../common)
Problem:
Currently, deck-cli state flag (--state) supports only one argument that can be a file or directory.
As filepath.Walk does not follow symlinks, deck will ignore symlinks found in the state directory.
Solution:
Supporting multiple arguments in state flag, we could load multiple state from different locations, as: