Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: deduplicate plugin configuration across multiple plugin instances #93

Closed
hbagdi opened this issue Nov 4, 2019 · 0 comments
Closed

feature request: deduplicate plugin configuration across multiple plugin instances #93

hbagdi opened this issue Nov 4, 2019 · 0 comments
Labels
feature New feature or request
Milestone
v0.7.0

Comments

@hbagdi
Copy link
Member

hbagdi commented Nov 4, 2019

Instead of duplicating plugin configuration across each plugin.

A good example is rate-limiting plugin applied on a combination of a route and a consumer for a large number of consumers.
@hbagdi hbagdi added the feature New feature or request label Nov 5, 2019
@hbagdi hbagdi mentioned this issue Nov 9, 2019
Closed
@hbagdi hbagdi added the awaiting feedback Something that is waiting on users to provide feedback label Nov 10, 2019
@hbagdi hbagdi added this to the v0.7.0 milestone Dec 7, 2019
@hbagdi hbagdi removed the awaiting feedback Something that is waiting on users to provide feedback label Dec 7, 2019
@hbagdi hbagdi mentioned this issue Dec 8, 2019
Open
hbagdi added a commit that referenced this issue Dec 8, 2019
@hbagdi
feat(file) implement _plugin_configs property for config deduplication
79ffda5 
Often times, multiple plugins share the same configuration and in such a
case having configuration duplicated across plugins is not very helpful.
In case of a change, all instances need to be updated.

`_plugin_configs` store the configuration of the plugins and they can be
referenced in any plugin via the `_config` parameter.

Q: Why is this feature implemented in code when YAML references can already
achieve the same?
A: To allow for cases when reference needs to exists across multiple
files. Imagine a case where ops introduces the redis connection params
and apps team set the plugin details.

Fix #93
@hbagdi hbagdi closed this as completed in 487383c Dec 8, 2019
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
feat(file) implement _plugin_configs property for config deduplication
f43b1d4 
Often times, multiple plugins share the same configuration and in such a
case having configuration duplicated across plugins is not very helpful.
In case of a change, all instances need to be updated.

`_plugin_configs` store the configuration of the plugins and they can be
referenced in any plugin via the `_config` parameter.

Q: Why is this feature implemented in code when YAML references can already
achieve the same?
A: To allow for cases when reference needs to exists across multiple
files. Imagine a case where ops introduces the redis connection params
and apps team set the plugin details.

Fix #93
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
feat(file) implement _plugin_configs property for config deduplication
7604fd8 
Often times, multiple plugins share the same configuration and in such a
case having configuration duplicated across plugins is not very helpful.
In case of a change, all instances need to be updated.

`_plugin_configs` store the configuration of the plugins and they can be
referenced in any plugin via the `_config` parameter.

Q: Why is this feature implemented in code when YAML references can already
achieve the same?
A: To allow for cases when reference needs to exists across multiple
files. Imagine a case where ops introduces the redis connection params
and apps team set the plugin details.

Fix #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@hbagdi