Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export SNIs as named as a separate entity #76

Closed
hbagdi opened this issue Sep 21, 2019 · 0 comments · Fixed by #87
Closed

Export SNIs as named as a separate entity #76

hbagdi opened this issue Sep 21, 2019 · 0 comments · Fixed by #87
Milestone
v0.6.0

Comments

@hbagdi
Copy link
Member

hbagdi commented Sep 21, 2019

Currently, snis are part of certificate itself in decK, which posses a compatibility problem with Kong's native format.
Change SNIs to be named in the file parsing logic but keep SNIs bundled with cert.

Introducing SNIs as another entity imposes a lot more overhead and it is likely that it doesn't gain us much.

See #56
@hbagdi hbagdi added this to the v0.6.0 milestone Sep 21, 2019
hbagdi added a commit that referenced this issue Oct 31, 2019
@hbagdi
fix(file) encode sni with name for compat with Kong's format
a80c01d 
Kong's format requires SNIs to be `name: foo.example.com`.
This is a breaking change for decK.

decK aims to be compatible with Kong's configuration format.

Fix #76
Update #56
@hbagdi hbagdi mentioned this issue Oct 31, 2019
Merged
hbagdi added a commit that referenced this issue Oct 31, 2019
@hbagdi
fix(file) encode sni with name for compat with Kong's format
ba747da 
Kong's format requires SNIs to be `name: foo.example.com`.
This is a breaking change for decK.

decK aims to be compatible with Kong's configuration format.

Fix #76
Update #56
hbagdi added a commit that referenced this issue Oct 31, 2019
@hbagdi
fix(file) encode sni with name for compat with Kong's format
0a10229 
Kong's format requires SNIs to be `name: foo.example.com`.
This is a breaking change for decK.

decK aims to be compatible with Kong's configuration format.

Fix #76
Update #56
From #87
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix(file) encode sni with name for compat with Kong's format
519eea8 
Kong's format requires SNIs to be `name: foo.example.com`.
This is a breaking change for decK.

decK aims to be compatible with Kong's configuration format.

Fix #76
Update #56
From #87
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix(file) encode sni with name for compat with Kong's format
0b2b67a 
Kong's format requires SNIs to be `name: foo.example.com`.
This is a breaking change for decK.

decK aims to be compatible with Kong's configuration format.

Fix #76
Update #56
From #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

fix(file) encode sni with name for compat with Kong's format Kong/deck
1 participant
@hbagdi