Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore credentials created for consumers without selectTag #65

Closed
hbagdi opened this issue Aug 20, 2019 · 0 comments · Fixed by #68
Closed

Ignore credentials created for consumers without selectTag #65

hbagdi opened this issue Aug 20, 2019 · 0 comments · Fixed by #68
Labels
priority/high
Milestone
v0.5.1

Comments

@hbagdi
Copy link
Member

hbagdi commented Aug 20, 2019

When select_tags feature is used to manage only a subset of Kong configuration, then any credential created for a consumer created outside of the managed config is loaded, decK errors out.

The problem here being that credentials are not tagged in Kong (yet) and hence Kong tries to load all the credentials.
@hbagdi hbagdi added this to the v0.5.1 milestone Aug 20, 2019
hbagdi added a commit that referenced this issue Aug 21, 2019
@hbagdi
fix(dump) ignore credentials for consumers not in the sub-set
12e3d1a 
Credentials in Kong are not tagged at the moment.

This leads to an error condition when only a subset where all credentials
If `select_tags` functionality is used, only a subset of consumers
are loaded in memory and this leads to a case where a credential could
belong to a consumer that is not part of the sub-set.
Such ErrNotFound errors are now ignored, if the select_tags feature is
being used.

The duplication of code here is absolutely shit.

Fix #65
@hbagdi hbagdi mentioned this issue Aug 21, 2019
Merged
hbagdi added a commit that referenced this issue Aug 21, 2019
@hbagdi
fix(dump) ignore credentials for consumers not in the sub-set
afd404e 
Credentials in Kong are not tagged at the moment.

This leads to an error condition when only a subset where all credentials
If `select_tags` functionality is used, only a subset of consumers
are loaded in memory and this leads to a case where a credential could
belong to a consumer that is not part of the sub-set.
Such ErrNotFound errors are now ignored, if the select_tags feature is
being used.

The duplication of code here is absolutely shit.

Fix #65
From #68
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix(dump) ignore credentials for consumers not in the sub-set
2262c68 
Credentials in Kong are not tagged at the moment.

This leads to an error condition when only a subset where all credentials
If `select_tags` functionality is used, only a subset of consumers
are loaded in memory and this leads to a case where a credential could
belong to a consumer that is not part of the sub-set.
Such ErrNotFound errors are now ignored, if the select_tags feature is
being used.

The duplication of code here is absolutely shit.

Fix #65
From #68
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix(dump) ignore credentials for consumers not in the sub-set
3df4668 
Credentials in Kong are not tagged at the moment.

This leads to an error condition when only a subset where all credentials
If `select_tags` functionality is used, only a subset of consumers
are loaded in memory and this leads to a case where a credential could
belong to a consumer that is not part of the sub-set.
Such ErrNotFound errors are now ignored, if the select_tags feature is
being used.

The duplication of code here is absolutely shit.

Fix #65
From #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/high
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging a pull request may close this issue.

fix(dump) ignore credentials for consumers not in the sub-set Kong/deck
1 participant
@hbagdi