Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(feature?): should allow same target.Target for different upstreams #57

Closed
zeeshen opened this issue Aug 19, 2019 · 1 comment
Closed

bug(feature?): should allow same target.Target for different upstreams #57

zeeshen opened this issue Aug 19, 2019 · 1 comment
Labels
bug Something isn't working priority/high
Milestone
v0.5.1

Comments

@zeeshen
Copy link
Contributor

zeeshen commented Aug 19, 2019

Currently, GetStateFromContent returns a duplicate target definitions found for: ... error when different upstreams have same target.

It's not rare that different services sharing the same group of pods in Kubernetes. Such restrictions causes the kubernetes-ingress-controller stop working. Maybe we can use ${upstream.id}/${target.Target} here as the id in TargetsCollection?
@zeeshen zeeshen mentioned this issue Aug 19, 2019
Closed
@hbagdi hbagdi added the bug Something isn't working label Aug 19, 2019
@zeeshen zeeshen mentioned this issue Aug 20, 2019
Closed
@hbagdi hbagdi added this to the v0.5.1 milestone Aug 20, 2019
@hbagdi
Copy link
Member

hbagdi commented Aug 24, 2019

Fixed in b6265c3

@hbagdi hbagdi closed this as completed Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority/high
Projects
None yet
Milestone
v0.5.1
Development

No branches or pull requests
2 participants
@zeeshen @hbagdi