Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io externs: promote export = const name:T to static class T #46

Closed
haxiomic opened this issue Jul 18, 2020 · 1 comment
Closed

Comments

@haxiomic
Copy link
Owner

socket.io has this pattern

declare const SocketIO: SocketIOStatic;
export = SocketIO;

interface SocketIOStatic {
}

The interface SocketIOStatic shouldn't be generated (but is) and the export = SocketIO; should promote the variable SocketIO into a class of static fields

@haxiomic haxiomic changed the title socket.io externs: promote export = const name:T to class T socket.io externs: promote export = const name:T to static class T Jul 18, 2020
@haxiomic
Copy link
Owner Author

haxiomic commented Sep 22, 2020

This seems to work correctly in 0.13.3, not sure on what's changed. SocketIOStatic is still generated but that's not a major issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant