Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the minimal p8s metric text format #98

Open
pilhuhn opened this issue Jan 14, 2017 · 1 comment
Open

Support the minimal p8s metric text format #98

pilhuhn opened this issue Jan 14, 2017 · 1 comment

Comments

@pilhuhn
Copy link
Member

pilhuhn commented Jan 14, 2017

The current code seems to expect that each metric is prefixed with a # TYPE line as in

# TYPE http_requests_total counter
http_requests_total{method="post",code="200"} 1027 1395066363000

P8s allows to skip the # TYPE as in

# Minimalistic line:
metric_without_timestamp_and_labels 12.47

We should support that.

@jmazzitelli
Copy link
Contributor

We are using the official prometheus client from prometheus.io to read prometheus endpoints. We should make sure the problem isn't in that third-party client library code.

But without the #TYPE line, we don't know what the type of the metric is (counter or gauge) so if the endpoint does NOT provide that, the user must provide the "type: " field in the endpoint YAML within the configmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants