Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate errors messages #53

Open
hats-bug-reporter bot opened this issue Jun 30, 2023 · 0 comments
Open

Duplicate errors messages #53

hats-bug-reporter bot opened this issue Jun 30, 2023 · 0 comments
Labels
bug Something isn't working low

Comments

@hats-bug-reporter
Copy link

Github username: @rotcivegaf
Submission hash (on-chain): 0xfdcd2ee440b94c80bd44794e4693bb7ee61a577ec8edddd4381099c4e39b9b10
Severity: low severity

Description:

Vulnerability Report

Description

Errors messages "105" and "106" are duplicated

File: packages/contracts/contracts/protocol/libraries/helpers/Errors.sol

134:    string public constant VO_WETH_SET_ONLY_ONCE = "105";

142:    string public constant LPAPR_ALREADY_SET = "105";
File: packages/contracts/contracts/protocol/libraries/helpers/Errors.sol

135:    string public constant VO_BAD_DENOMINATION = "106";

144:    string public constant LPC_TREASURY_ADDRESS_ZERO = "106"; //assetmappings does not allow setting collateral

Attack Scenario

Being duplicates could lead to confusion, the AAVE documentation does not have duplicate codes
@hats-bug-reporter hats-bug-reporter bot added the bug Something isn't working label Jun 30, 2023
@ksyao2002 ksyao2002 added the low label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ksyao2002