Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Upgraded new_address itself cannot be upgraded. Stucked in use forever #41

Open
hats-bug-reporter bot opened this issue Mar 21, 2024 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right

Comments

@hats-bug-reporter
Copy link

Github username: @kodakr
Twitter username: @Kodak_Rome
Submission hash (on-chain): 0x583795c4d11c46f50c86555838ec16cca3bc363cff2e84a4a26a7cfb5270e867
Severity: high

Description:
In eth\contracts\Migrations.sol::upgrade(), This implementation which is an exact copy of the current Migration.sol cannot be called by it. Hence cannot be setCompleted()
Recall that the above named function is restricted to only the owner who is the msg.sender at deployment. Current Migration.sol is not the deployer hence lacks this access.

  • cannot be upgraded
  • setCompleted() is restricted & cannot be called by current Migration.sol
    This implies that the migration.sol contract is unUpgradeable.
@hats-bug-reporter hats-bug-reporter bot added the bug Something isn't working label Mar 21, 2024
@fbielejec
Copy link

fbielejec commented Apr 2, 2024

Does not follow submission guideline - no POC, but mostly marking as invalid as Migrations.sol should not be upgradeable at all. Migrations is just a counter, and using is an opt-in for migration scripts that can (but need not to) check whether a previous migration script was applied (context dependent).

@fbielejec
Copy link

duplicate with #3

@krzysztofziobro krzysztofziobro added the duplicate This issue or pull request already exists label Apr 2, 2024
@krzysztofziobro krzysztofziobro closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
@fonstack fonstack added the invalid This doesn't seem right label Apr 17, 2024
@fonstack fonstack reopened this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants