Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Batching queries #1812

Closed
rick-lansink opened this issue Mar 18, 2019 · 7 comments · Fixed by #3605
Closed

Feature Request: Batching queries #1812

rick-lansink opened this issue Mar 18, 2019 · 7 comments · Fixed by #3605
Assignees
Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint s/wip Status: This issue is a work in progress

Comments

@rick-lansink
Copy link

As it currently stands, the graphql-engine is unable to process batched queries (batched query example). The following response is returned when attempting to batch queries through Apollo:
{"errors":[{"extensions":{"path":"$","code":"parse-failed"},"message":"When parsing the constructor GraphQLRequest of type Hasura.GraphQL.Transport.HTTP.Protocol.GraphQLRequest expected Object but got Array."}]}

@0x777 0x777 added k/enhancement New feature or improve an existing feature c/server Related to server e/quickfix can be wrapped up in few hours p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Mar 19, 2019
@madhujahagirdar
Copy link

I would love to have this feature so that i can integrate Prisma plugin in VSCode.

@ecthiender ecthiender self-assigned this Jun 6, 2019
@EddieVallejos
Copy link

+1

@nmaquet
Copy link

nmaquet commented Aug 11, 2019

+1

@rick-lansink
Copy link
Author

What's the status on this?

@OLDIN
Copy link

OLDIN commented Oct 23, 2019

+1

@bkniffler
Copy link
Contributor

bkniffler commented Oct 23, 2019

Come on guys, there are things like reactions now build into github. I'd rather have notifications for important messages only and these '+1' add no substantial value to an issue. God knows how many people are subscribed and will be unnecessarily bothered.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-conversations-on-github#reacting-to-ideas-in-comments

@0x777 0x777 added p/high candidate for being included in the upcoming sprint and removed p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Nov 5, 2019
@marionschleifer marionschleifer added the support/needs-action support ticket that requires action by team label Nov 20, 2019
@coco98 coco98 assigned paf31 and unassigned rakeshkky Dec 2, 2019
paf31 added a commit to paf31/graphql-engine that referenced this issue Dec 4, 2019
@paf31 paf31 added the s/wip Status: This issue is a work in progress label Dec 4, 2019
@marionschleifer marionschleifer removed the support/needs-action support ticket that requires action by team label Dec 12, 2019
@lexi-lambda
Copy link
Contributor

Reopening this issue after some discussion in #3490 pending a further decision about what we want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/enhancement New feature or improve an existing feature p/high candidate for being included in the upcoming sprint s/wip Status: This issue is a work in progress
Projects
None yet