issue with modifying custom function

[rikinsk-zz]

modifying custom function not functioning as expected

• running with Track this enabled throws error
• modifying arguments doesnt do anything (edit: seems to be creating a duplicate fn in the background)

[rakeshkky]

• running with Track this enabled throws error

Console makes track_function query, which obviously fails since the function tracked already.

• modifying arguments doesnt do anything (edit: seems to be creating a duplicate fn in the background)

Postgres supports function overloading. We can have more than one functions with same schema and name but with different input argument types. GraphQL Engine do not support overloaded functions. It is supposed to restrict overloading an already tracked function if it is being done through run_sql query. I'm adding this check here.

[karthikvt26]

@rikinsk @rakeshkky If I track from where the user is coming to Raw SQL page and not send a track query. It should do it right? will there be any implications of this?

The only problem I see is that if user tries to change the signature of the function (name or parameters) it will be affected.

Let me know your views.

[rikinsk-zz]

The Track this behaviour is consistent with modifying views as well. Altleast that's a good thing.

But I am not a fan of the experience. If something is already tracked and I send a modify request with track this enabled, the action shouldn't fail.

@0x777 Thoughts?

[0x777]

Maybe we can add ignore_if_tracked flag to track_table and track_function queries, similar to IF NOT EXISTS in sql?

[0x777]

I think the root cause is our current solution of redirecting to the SQL page for modifying a view/function.