Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Find all references #62

Closed
martrik opened this issue Dec 18, 2017 · 5 comments
Closed

Implement Find all references #62

martrik opened this issue Dec 18, 2017 · 5 comments
Labels

Comments

@martrik
Copy link
Collaborator

martrik commented Dec 18, 2017

No description provided.

@ryu1kn
Copy link
Contributor

ryu1kn commented Dec 19, 2017

Intero provides a command :uses that "find uses of an identifier in a module."

https://github.com/commercialhaskell/intero/blob/master/TOOLING.md

When I executed :uses on the use of a in A.hs, it gave me the locations of as in both A.hs and B.hs. But when I did it in B.hs, it only gave a's location in B.hs. So not enough to use it for a "find usages/references" feature 😞

-- A.hs
foo = a

-- B.hs
a = ...

@martrik
Copy link
Collaborator Author

martrik commented Dec 20, 2017

Hi @ryu1kn thank you for pointing that out. I think that despite this limitation it might be worth giving it a try, as it is probably the only feasible way of implementing the "find al references". Are you planing on working on this? We are not actively adding new features to Haskelly so it might take a while for us to implement it.

@ryu1kn
Copy link
Contributor

ryu1kn commented Dec 20, 2017

Sure, as I've already had a look at this a bit, I believe I know where to change 😉

@martrik
Copy link
Collaborator Author

martrik commented Dec 21, 2017

That's awesome. Looking forward to your PR!

@martrik
Copy link
Collaborator Author

martrik commented Dec 24, 2017

Thanks to @ryu1kn and his PR (#64) we can now close this PR. The feature has been included in version 0.5.0.

@martrik martrik closed this as completed Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants