Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions are duplicated if imports are #950

Closed
ndmitchell opened this issue Mar 8, 2020 · 3 comments · Fixed by haskell/ghcide#837
Closed

Completions are duplicated if imports are #950

ndmitchell opened this issue Mar 8, 2020 · 3 comments · Fixed by haskell/ghcide#837

Comments

@ndmitchell
Copy link
Collaborator

image

Both these point at GHC.Util. Would be great to avoid generating them first, but a simple nubOrd on showing the completions might be worthwhile too. Root cause is that I am importing the module GHC.Util twice.

@ndmitchell ndmitchell changed the title Completions are sometimes duplicated Completions are duplicated if imports are Mar 8, 2020
@jneira
Copy link
Member

jneira commented Sep 24, 2020

It is reproduced with lastest ghcide

@botal9
Copy link
Contributor

botal9 commented Sep 27, 2020

Hi! I'd be happy to work on this issue.

@ndmitchell
Copy link
Collaborator Author

Thanks @botal9 - that would be great. There are three relevant modules - the first three of https://github.com/haskell/ghcide/search?q=completion. Not sure at what level to reduce it - probably best to write a test, and then experiment with where to remove the duplicate.

@pepeiborra pepeiborra transferred this issue from haskell/ghcide Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants